Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: video: introduce "GET" sub-operations #78603

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 87 additions & 0 deletions drivers/video/video_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@

#include <zephyr/kernel.h>
#include <zephyr/drivers/video.h>
#include <zephyr/drivers/video-controls.h>

#include "video_common.h"

#if defined(CONFIG_VIDEO_BUFFER_USE_SHARED_MULTI_HEAP)
#include <zephyr/multi_heap/shared_multi_heap.h>
Expand Down Expand Up @@ -83,3 +86,87 @@ void video_buffer_release(struct video_buffer *vbuf)
VIDEO_COMMON_FREE(block->data);
}
}

int video_get_range_int(unsigned int cid, int *value, int min, int max, int def)
{
switch (cid & VIDEO_CTRL_GET_MASK) {
case VIDEO_CTRL_GET_MIN:
*value = min;
return 0;
case VIDEO_CTRL_GET_MAX:
*value = max;
return 0;
case VIDEO_CTRL_GET_DEF:
*value = def;
return 0;
case VIDEO_CTRL_GET_CUR:
return 1;
default:
return -ENOTSUP;
}
}

int video_get_range_int64(unsigned int cid, int64_t *value, int64_t min, int64_t max, int64_t def)
{
switch (cid & VIDEO_CTRL_GET_MASK) {
case VIDEO_CTRL_GET_MIN:
*value = min;
return 0;
case VIDEO_CTRL_GET_MAX:
*value = max;
return 0;
case VIDEO_CTRL_GET_DEF:
*value = def;
return 0;
case VIDEO_CTRL_GET_CUR:
return 1;
default:
return -ENOTSUP;
}
}

int video_check_range_int(const struct device *dev, unsigned int cid, int value)
{
int min;
int max;
int ret;

ret = video_get_ctrl(dev, cid | VIDEO_CTRL_GET_MIN, &min);
if (ret < 0) {
return ret;
}

ret = video_get_ctrl(dev, cid | VIDEO_CTRL_GET_MAX, &max);
if (ret < 0) {
return ret;
}

if (value < min || value > max || min > max) {
return -ERANGE;
}

return 0;
}

int video_check_range_int64(const struct device *dev, unsigned int cid, int64_t value)
{
int64_t min;
int64_t max;
int ret;

ret = video_get_ctrl(dev, cid | VIDEO_CTRL_GET_MIN, &min);
if (ret < 0) {
return ret;
}

ret = video_get_ctrl(dev, cid | VIDEO_CTRL_GET_MAX, &max);
if (ret < 0) {
return ret;
}

if (value < min || value > max || min > max) {
return -ERANGE;
}

return 0;
}
68 changes: 68 additions & 0 deletions drivers/video/video_common.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
/*
* Copyright (c) 2024, tinyVision.ai Inc.
*
* SPDX-License-Identifier: Apache-2.0
*/

#ifndef ZEPHYR_INCLUDE_VIDEO_COMMON_H
#define ZEPHYR_INCLUDE_VIDEO_COMMON_H

/**
* @brief Provide the minimum/maximum/default integer value depending on the CID.
*
* Video CIDs can contain sub-operations. This function facilitates
* implementation of video controls in the drivers by handling these
* the range-related CIDs.
*
* @param cid The Video Control ID which contains the operation.
* @param value The value, selected among @p min, @p max and @p def.
* @param min The minimum value returned if the CID requested it.
* @param max The maximum value returned if the CID requested it.
* @param def The default value returned if the CID requested it.
*
* @return 0 if the operation was regarding a range CID and the value could
* be set. In which case, there is nothing else to do than returning 0.
* @return 1 if the operation is not for the range, but the current value,
* in which case it is the duty of the driver to query the current
* value to the hardware
* @return A negative error code if an error occurred.
*
* @{
*/

/** Signed integer version */
int video_get_range_int(unsigned int cid, int *value, int min, int max, int def);

/** Signed 64-bit version */
int video_get_range_int64(unsigned int cid, int64_t *value, int64_t min, int64_t max, int64_t def);

/**
* @}
*/

/**
* @brief Check if the integer value is within range for this CID.
*
* Before setting a video control, a driver might be interested in checking
* if it is within a valid range. This function facilitates it by reusing the
* video_get_ctrl() API using @c VIDEO_CTRL_GET_MIN and @c VIDEO_CTRL_GET_MAX
* to validate the input.
*
* @param dev The video device to query to learn about the min and max.
* @param cid The CID for which to check the range.
* @param value The integer value that must be matched against the range.
*
* @{
*/

/** Signed integer version */
int video_check_range_int(const struct device *dev, unsigned int cid, int value);

/** Signed 64-bit version */
int video_check_range_int64(const struct device *dev, unsigned int cid, int64_t value);

/**
* @}
*/

#endif /* ZEPHYR_INCLUDE_VIDEO_COMMON_H */
25 changes: 25 additions & 0 deletions include/zephyr/drivers/video-controls.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,31 @@
* @}
*/

/**
* @name Control Get operations
*
* Extra flags for video controls to inquire about the dimensions of an existing
* control: the minimum, maximum, or default value.
*
* For instance, OR-ing @c VIDEO_CID_CAMERA_EXPOSURE and @c VIDEO_CTRL_GET_MAX
* permits to query the maximum exposure time instead of the current exposure
* time.
*
* If no Control Get flag is added to a CID, the behavior is to fetch the current
* value as with @ref VIDEO_CTRL_GET_CUR.
* These must only be used along with the @ref video_get_ctrl() API.
*
* @{
*/
#define VIDEO_CTRL_GET_CUR 0x00000000 /**< Get the current value */
#define VIDEO_CTRL_GET_MIN 0x00001000 /**< Get the minimum value */
#define VIDEO_CTRL_GET_MAX 0x00002000 /**< Get the maximum value */
#define VIDEO_CTRL_GET_DEF 0x00003000 /**< Get the default value */
#define VIDEO_CTRL_GET_MASK 0x0000f000 /**< Mask for get operations */
/**

Check notice on line 66 in include/zephyr/drivers/video-controls.h

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change

include/zephyr/drivers/video-controls.h:66 -#define VIDEO_CTRL_GET_CUR 0x00000000 /**< Get the current value */ -#define VIDEO_CTRL_GET_MIN 0x00001000 /**< Get the minimum value */ -#define VIDEO_CTRL_GET_MAX 0x00002000 /**< Get the maximum value */ -#define VIDEO_CTRL_GET_DEF 0x00003000 /**< Get the default value */ -#define VIDEO_CTRL_GET_MASK 0x0000f000 /**< Mask for get operations */ +#define VIDEO_CTRL_GET_CUR 0x00000000 /**< Get the current value */ +#define VIDEO_CTRL_GET_MIN 0x00001000 /**< Get the minimum value */ +#define VIDEO_CTRL_GET_MAX 0x00002000 /**< Get the maximum value */ +#define VIDEO_CTRL_GET_DEF 0x00003000 /**< Get the default value */ +#define VIDEO_CTRL_GET_MASK 0x0000f000 /**< Mask for get operations */
* @}
*/

/**
* @name Generic class control IDs
* @{
Expand Down
2 changes: 1 addition & 1 deletion include/zephyr/drivers/video.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* @brief Video Interface
* @defgroup video_interface Video Interface
* @since 2.1
* @version 1.0.0
* @version 1.1.0
* @ingroup io_interfaces
* @{
*/
Expand Down
Loading