-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: uart: esp32: Test configuration #81159
Open
raffarost
wants to merge
3
commits into
zephyrproject-rtos:main
Choose a base branch
from
raffarost:tests/uart_loop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+258
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raffarost
force-pushed
the
tests/uart_loop
branch
3 times, most recently
from
November 9, 2024 02:09
339219f
to
a2f11b5
Compare
raffarost
changed the title
tests: uart: esp32: Add configs for devices
tests: uart: esp32: Test configuration
Nov 9, 2024
rruuaanng
added
area: UART
Universal Asynchronous Receiver-Transmitter
area: Tests
Issues related to a particular existing or missing test
platform: ESP32
Espressif ESP32
labels
Nov 9, 2024
zephyrbot
requested review from
dcpleung,
LucasTambor,
marekmatej,
sylvioalves,
uLipe and
wmrsouza
November 12, 2024 14:02
dcpleung
previously approved these changes
Nov 12, 2024
wmrsouza
previously approved these changes
Nov 12, 2024
sylvioalves
reviewed
Nov 12, 2024
sylvioalves
previously approved these changes
Nov 12, 2024
marekmatej
previously approved these changes
Nov 12, 2024
raffarost
dismissed stale reviews from marekmatej, sylvioalves, wmrsouza, and dcpleung
via
November 14, 2024 16:24
845ddf4
raffarost
force-pushed
the
tests/uart_loop
branch
2 times, most recently
from
November 14, 2024 16:40
845ddf4
to
8824756
Compare
sylvioalves
previously approved these changes
Nov 14, 2024
wmrsouza
previously approved these changes
Nov 14, 2024
dcpleung
requested changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are amending the changes, please leave the whitespace changes out of functional changes. This will make future reviewing (and git log/show) of code easier to understand.
Add option (BAUDRATE_FROM_DTS) to get baudrate value from device tree, for devices which differ from standard (115200). Signed-off-by: Raffael Rostagno <[email protected]>
Return standard baudrate on a uart_config_get call instead of rough calculated numbers. Signed-off-by: Raffael Rostagno <[email protected]>
Add test configuration for ESP32 devices. Signed-off-by: Raffael Rostagno <[email protected]>
raffarost
force-pushed
the
tests/uart_loop
branch
from
November 17, 2024 21:24
8824756
to
6217647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Tests
Issues related to a particular existing or missing test
area: UART
Universal Asynchronous Receiver-Transmitter
platform: ESP32
Espressif ESP32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add file configs for ESP32 devices for CI testing.
Get baudrate from device tree for
uart_basic_api
anduart_elementary
tests.Fix esp32 uart driver function
uart_get_config
to return standard baudrate value.