-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MKS CANable V2.0 #81366
base: main
Are you sure you want to change the base?
MKS CANable V2.0 #81366
Conversation
@henrikbrixandersen You will see an overlay for this board in CANnectivity later. ;) Thus please take a look too. |
ce12700
to
b6f5079
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Board is OK, please fix ordering issue
Thank you for you review. Great to see a feedback from hwv2 guy :) I'll do necessary changes today late night. |
858f91e
to
bbe0276
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates need squashing i.e. 2 commits
1bd250e
to
ddf9bfd
Compare
Thank you. It is done now. |
So the second vendor update commit needs squashing into the first vendor update commit and the second board commit needs squashing into the first board commit. Something like this:
Now you should have 2 commits |
Got it. Will do. |
Add Makerbase Co., Ltd. board vendor Signed-off-by: Alexander Kozhinov <[email protected]>
A cheap and affordable stm32g4 based simple CAN and CAN-FD to usb adapter board Reviewed-by: Erwan Gouriou <[email protected]> Signed-off-by: Alexander Kozhinov <[email protected]>
ddf9bfd
to
f66f16a
Compare
add new board MKS CANable V2.0 Please refer to added documentation for more information.
The hardware of the board can be dound under: https://github.com/makerbase-mks/CANable-MKS