Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MKS CANable V2.0 #81366

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KozhinovAlexander
Copy link
Collaborator

add new board MKS CANable V2.0 Please refer to added documentation for more information.
The hardware of the board can be dound under: https://github.com/makerbase-mks/CANable-MKS

@KozhinovAlexander
Copy link
Collaborator Author

@henrikbrixandersen You will see an overlay for this board in CANnectivity later. ;) Thus please take a look too.

@KozhinovAlexander KozhinovAlexander force-pushed the mks_canable_v2 branch 2 times, most recently from ce12700 to b6f5079 Compare November 13, 2024 23:59
@KozhinovAlexander KozhinovAlexander requested review from erwango, decsny and galak and removed request for galak and decsny November 13, 2024 23:59
@KozhinovAlexander KozhinovAlexander changed the title Add new board MKS CANable V2.0 MKS CANable V2.0 Nov 14, 2024
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Board is OK, please fix ordering issue

@KozhinovAlexander
Copy link
Collaborator Author

Board is OK, please fix ordering issue

Thank you for you review. Great to see a feedback from hwv2 guy :) I'll do necessary changes today late night.

boards/makerbase/mks_canable_v20/doc/index.rst Outdated Show resolved Hide resolved
boards/makerbase/mks_canable_v20/doc/index.rst Outdated Show resolved Hide resolved
boards/makerbase/mks_canable_v20/doc/index.rst Outdated Show resolved Hide resolved
boards/makerbase/mks_canable_v20/doc/index.rst Outdated Show resolved Hide resolved
boards/makerbase/mks_canable_v20/doc/index.rst Outdated Show resolved Hide resolved
boards/makerbase/mks_canable_v20/mks_canable_v20.dts Outdated Show resolved Hide resolved
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates need squashing i.e. 2 commits

@KozhinovAlexander
Copy link
Collaborator Author

Updates need squashing i.e. 2 commits

Thank you. It is done now.

@nordicjm
Copy link
Collaborator

Updates need squashing i.e. 2 commits

Thank you. It is done now.

So the second vendor update commit needs squashing into the first vendor update commit and the second board commit needs squashing into the first board commit. Something like this:

git rebase -i 40cd35e56d43716bdbdeafafa6c356407121ca2e
  change first to edit, third to fixup, forth to drop
git cherry-pick ddf9bfdf02006c2dc4e2012ae5ad93a3a0fde584
git rebase --continue
git rebase -i 40cd35e56d43716bdbdeafafa6c356407121ca2e
  change second to fixup

Now you should have 2 commits

@KozhinovAlexander
Copy link
Collaborator Author

Updates need squashing i.e. 2 commits

Thank you. It is done now.

So the second vendor update commit needs squashing into the first vendor update commit and the second board commit needs squashing into the first board commit. Something like this:

git rebase -i 40cd35e56d43716bdbdeafafa6c356407121ca2e
  change first to edit, third to fixup, forth to drop
git cherry-pick ddf9bfdf02006c2dc4e2012ae5ad93a3a0fde584
git rebase --continue
git rebase -i 40cd35e56d43716bdbdeafafa6c356407121ca2e
  change second to fixup

Now you should have 2 commits

Got it. Will do.

Add Makerbase Co., Ltd. board vendor

Signed-off-by: Alexander Kozhinov <[email protected]>
A cheap and affordable stm32g4 based simple CAN and CAN-FD to usb
adapter board

Reviewed-by: Erwan Gouriou <[email protected]>
Signed-off-by: Alexander Kozhinov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants