sensor: adxl3xx: Move run-time ODR changes from cfg to data #83852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
asemjonovs,
avisconti,
galak,
jeppenodgaard,
MaureenHelm,
microbuilder,
ozersa,
teburd,
tristan-google,
ttmut and
yperess
teburd
previously approved these changes
Jan 11, 2025
ttmut
previously approved these changes
Jan 12, 2025
|
I'll change this PR based on feedback obtained in the issue: #83853 (comment) |
ubieda
force-pushed
the
croxel/adxl-fix-cfg-struct-modified-at-run-time
branch
from
cbba1b4 to
ff54222
Compare
ubieda
changed the title
glenn-andrews
previously approved these changes
Jan 14, 2025
Config struct is constant and attempting to modify it triggers a fault. Signed-off-by: Luis Ubieda <[email protected]>
ubieda
force-pushed
the
croxel/adxl-fix-cfg-struct-modified-at-run-time
branch
from
ff54222 to
6e02da9
Compare
|
Fixed a typo on the |
glenn-andrews
approved these changes
Jan 14, 2025
teburd
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfgstruct is constant and attempting to modify it triggers a fault. Instead, moved todata.Fixes #83853