Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: when exceptSelector is defined and e.target is empty an error is thrown from closest function #266

Merged
merged 2 commits into from
Oct 3, 2024
Merged

fix: when exceptSelector is defined and e.target is empty an error is thrown from closest function #266

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2254d7f
fix: when exceptSelector is set and e.target is empty
Sep 30, 2024
6c98feb
review: remove comma
Scra3 Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ember-click-outside/src/modifiers/on-click-outside.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export default class ClickOutsideModifier extends Modifier {
this.eventHandler = this._createHandler(
element,
this.action,
this.exceptSelector
this.exceptSelector,
Scra3 marked this conversation as resolved.
Show resolved Hide resolved
);
this.cancelOutsideListenerSetup = next(this, this._addClickOutsideListener);
}
Expand All @@ -88,7 +88,7 @@ export default class ClickOutsideModifier extends Modifier {

_createHandler(element, action, exceptSelector) {
return (e) => {
if (exceptSelector && closest(e.target, exceptSelector)) {
if (exceptSelector && e.target && closest(e.target, exceptSelector)) {
return;
}

Expand Down
Loading