Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Value and Lint Fixes #122

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Initial Value and Lint Fixes #122

merged 2 commits into from
Feb 23, 2024

Conversation

azaidy
Copy link
Contributor

@azaidy azaidy commented Feb 23, 2024

This PR contains a fix to ensure the first packet to fifo flex merge buffer is correctly flopped. The fix ensures packet boundary is recognized for the very first packet to fifo flex after reset. This is done by initializing latch_eom as 1 on reset.

Additionally, the PR contains lint cleanup for byte measurement using umi_len and umi_size.

@azaidy azaidy requested a review from volkamir February 23, 2024 18:20
Copy link
Contributor

@volkamir volkamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@azaidy azaidy merged commit 2484ae4 into main Feb 23, 2024
11 checks passed
@azaidy azaidy deleted the ali/fixes branch February 23, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants