-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump to use go1.23 #4279
base: master
Are you sure you want to change the base?
Conversation
Thanks for your PR! Would you please let me know why we need to upgrade go to 1.21? |
I just run the |
from golang team perspective, they only maintains the most two recent major release lines. 1.21 and 1.22 (see https://endoflife.date/go) |
Homebrew also works on go 1.20. Homebrew/homebrew-core#178656 is already merged. But please let us discuss on upgrading go version with goctl. Thanks! |
tools/goctl/go.mod
Outdated
@@ -1,6 +1,8 @@ | |||
module github.com/zeromicro/go-zero/tools/goctl | |||
|
|||
go 1.20 | |||
go 1.21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this version have to be upgraded to 1.21? I recommend staying consistent with go-zero's version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately, it might be the case, since the go toolchain is only added in 1.21, https://go.dev/blog/toolchain
I would imagine for the future it would be easier.
Also what is the hurdle of using go1.21+?
it is just unblocking the homebrew build (packaging build does not necessarily the same as the project build, which they should be the same for the most cases), we can totally accommodate the desired changes in here for the next release build |
goctl better to use the same go version as go-zero, because I think if go-zero work with a go version, goctl should do as well. |
yeah, I can update both to go1.21 (I dont see why not) |
actually move the workflow syntax change into a separate PR, #4286 |
Thanks! It's already merged. |
Signed-off-by: Rui Chen <[email protected]>
94ca481
to
19c5fc3
Compare
update go.mod and go.sum for Homebrew/homebrew-core#178656