Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to use go1.23 #4279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chenrui333
Copy link
Contributor

update go.mod and go.sum for Homebrew/homebrew-core#178656

@kevwan
Copy link
Contributor

kevwan commented Jul 27, 2024

Thanks for your PR!

Would you please let me know why we need to upgrade go to 1.21?

@chenrui333
Copy link
Contributor Author

Would you please let me know why we need to upgrade go to 1.21?

I just run the go mod tidy with go 1.22.5 and it got populated automatically. (homebrew side also built with go 1.22.5 as well)

@chenrui333
Copy link
Contributor Author

from golang team perspective, they only maintains the most two recent major release lines. 1.21 and 1.22 (see https://endoflife.date/go)

Copy link

codecov bot commented Jul 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (8690859) to head (19c5fc3).
Report is 133 commits behind head on master.

Additional details and impacted files

see 262 files with indirect coverage changes

@kevwan
Copy link
Contributor

kevwan commented Jul 28, 2024

Homebrew also works on go 1.20.

Homebrew/homebrew-core#178656 is already merged.

But please let us discuss on upgrading go version with goctl. Thanks!

@@ -1,6 +1,8 @@
module github.com/zeromicro/go-zero/tools/goctl

go 1.20
go 1.21
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this version have to be upgraded to 1.21? I recommend staying consistent with go-zero's version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately, it might be the case, since the go toolchain is only added in 1.21, https://go.dev/blog/toolchain


I would imagine for the future it would be easier.

Also what is the hurdle of using go1.21+?

@chenrui333
Copy link
Contributor Author

But please let us discuss on upgrading go version with goctl. Thanks!

it is just unblocking the homebrew build (packaging build does not necessarily the same as the project build, which they should be the same for the most cases), we can totally accommodate the desired changes in here for the next release build

@kevwan
Copy link
Contributor

kevwan commented Jul 29, 2024

goctl better to use the same go version as go-zero, because I think if go-zero work with a go version, goctl should do as well.

@chenrui333
Copy link
Contributor Author

goctl better to use the same go version as go-zero, because I think if go-zero work with a go version, goctl should do as well.

yeah, I can update both to go1.21 (I dont see why not)

@chenrui333 chenrui333 requested a review from kesonan July 30, 2024 16:03
@chenrui333
Copy link
Contributor Author

actually move the workflow syntax change into a separate PR, #4286

@kevwan kevwan added area/goctl Categorizes issue or PR as related to goctl. do-not-merge/hold Indicates that a PR should not merge because of known issues or need more discussion. labels Aug 3, 2024
@kevwan
Copy link
Contributor

kevwan commented Aug 3, 2024

actually move the workflow syntax change into a separate PR, #4286

Thanks! It's already merged.

@chenrui333 chenrui333 changed the title build: fix goctl build chore: bump to use go1.23 Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/goctl Categorizes issue or PR as related to goctl. do-not-merge/hold Indicates that a PR should not merge because of known issues or need more discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants