Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(httpc): added MetricsInterceptor in DoRequest #4291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Suyghur
Copy link
Contributor

@Suyghur Suyghur commented Aug 2, 2024

until now, MetricsInterceptor not used in httpc.

help to code review, plz~

@kevwan

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.11%. Comparing base (8690859) to head (f1d8a19).
Report is 159 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
rest/httpc/requests.go 100.00% <100.00%> (ø)
rest/httpc/service.go 100.00% <100.00%> (ø)

... and 253 files with indirect coverage changes

@kevwan kevwan requested a review from MarkJoyMa August 3, 2024 05:50
@Suyghur Suyghur requested a review from MarkJoyMa August 3, 2024 09:38
@kevwan kevwan added feature Marks an issue or PR as related to a new feature. area/restful Categorizes issue or PR as related to restful apis. labels Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/restful Categorizes issue or PR as related to restful apis. feature Marks an issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants