-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat Example Project #16
base: master
Are you sure you want to change the base?
Conversation
So, Cypress has a limitation that prevents it from being used to test across multiple windows. It recommends stubbing that behavior instead, which isn't really a great end to end test. It makes a lot of sense to do that, but not with this example project. I'm going to reduce the scope of this pull request for now. The rest of the work is finished, however, so that could prove useful to others seeking to use the library in its current state, and it'll also be very useful for testing when moving towards an async/await API. |
One more thing... I just realized, I forgot to exclude the example project from the jszmq example config when tests are compiled. I had split them up into two separate configs as an optimization step. At this point I forget why... But I'll add the example node_modules to the clear:all script, too. |
That should be RFR now. 👍 |
I think #17 should be merged before this one. The package version on this branch is still |
This PR is a small example project of a chat app written with jszmq. I decided to do this work first before the async/await work in #4 because this work will help a great deal with the conversion.
Tasks