Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poller.remove socket disposed fix #835

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Poller.remove socket disposed fix #835

wants to merge 33 commits into from

Commits on Dec 3, 2019

  1. added NetMQPollerTest.RemoveAndDisposeSocket() as a repro for issue z… 

    …eromq#834
    @jasells
    jasells committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    3b8dbb9 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2019

  1. Task refactor of .Remove(ISocketPollable) passes test!

    @jasells
    jasells committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    d0f2725 View commit details
    Browse the repository at this point in the history

  2. speed up the test a little

    @jasells
    jasells committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    53e1833 View commit details
    Browse the repository at this point in the history

  3. async fix supporting .NET40, broke a test

    @jasells
    jasells committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    68429d7 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2019

  1. un-break the API back to sycnronous (but now working)

    @jasells
    jasells committed Dec 8, 2019
    Configuration menu
    Copy the full SHA
    dea90f4 View commit details
    Browse the repository at this point in the history

  2. rename new test to avoid confusion

    @jasells
    jasells committed Dec 8, 2019
    Configuration menu
    Copy the full SHA
    6b344ca View commit details
    Browse the repository at this point in the history

  3. fixed RemoveAndDispose()

    @jasells
    jasells committed Dec 8, 2019
    Configuration menu
    Copy the full SHA
    c879804 View commit details
    Browse the repository at this point in the history

  4. fix other Remove methods

    @jasells
    jasells committed Dec 8, 2019
    Configuration menu
    Copy the full SHA
    54c2931 View commit details
    Browse the repository at this point in the history

  5. clean up the RUn method for .NET40 compat

    @jasells
    jasells committed Dec 8, 2019
    Configuration menu
    Copy the full SHA
    bc362a9 View commit details
    Browse the repository at this point in the history

  6. undo changes in RemoveThrowsIfSocketAlreadyDisposed

    @jasells
    jasells committed Dec 8, 2019
    Configuration menu
    Copy the full SHA
    98a0f00 View commit details
    Browse the repository at this point in the history

  7. fixing spacing complaints

    @jasells
    jasells committed Dec 8, 2019
    Configuration menu
    Copy the full SHA
    a3819e1 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2019

  1. return task from tests

    @jasells
    jasells committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    4f3b1e6 View commit details
    Browse the repository at this point in the history

  2. fixing wait() calls

    @jasells
    jasells committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    33816cb View commit details
    Browse the repository at this point in the history

  3. use Task.Factory.StartNew

    @jasells
    jasells committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    bda8b3f View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2020

  1. initial refactor works, except for one test.

    @jasells
    jasells committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    cb16939 View commit details
    Browse the repository at this point in the history

  2. fix Selector to handle disposed sockets

    @jasells
    jasells committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    544bb94 View commit details
    Browse the repository at this point in the history

  3. added comment about previous commmit

    @jasells
    jasells committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    87b7649 View commit details
    Browse the repository at this point in the history

  4. removed comment

    @jasells
    jasells committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    92163b1 View commit details
    Browse the repository at this point in the history

  5. fix region tag formatting

    @jasells
    jasells committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    51457d1 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2020

  1. sync with master

    @jasells
    jasells committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    fce2bb0 View commit details
    Browse the repository at this point in the history

  2. updated comments

    @jasells
    jasells committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    38910d8 View commit details
    Browse the repository at this point in the history

  3. cleaer names for async socket remove tests

    @jasells
    jasells committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    3bacfb8 View commit details
    Browse the repository at this point in the history

  4. I believe this should address the net45/net40 Task.FromResult() concern

    @jasells
    jasells committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    455f6b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. ensure tasks are queued on the poller, not the task pool.

    @jasells
    jasells committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    52fa20e View commit details
    Browse the repository at this point in the history

  2. remove the dictionary checks.

    @jasells
    jasells committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    884d4ea View commit details
    Browse the repository at this point in the history

  3. fix indentation

    @jasells
    jasells committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    9f17258 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. removed comment that needs seperate PR

    @jasells
    jasells committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    3ea0693 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. added RemoveAsync(Socket ) overload

    @jasells
    jasells committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    72ebdbc View commit details
    Browse the repository at this point in the history

  2. comment update

    @jasells
    jasells committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    c14f9f9 View commit details
    Browse the repository at this point in the history

  3. added REmoveASync(timer) overload and test

    @jasells
    jasells committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    0a767c6 View commit details
    Browse the repository at this point in the history

  4. fix depricated message

    @jasells
    jasells committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    fa5e49b View commit details
    Browse the repository at this point in the history

  5. refactored ContainsAsync() methods

    @jasells
    jasells committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    83a34b6 View commit details
    Browse the repository at this point in the history

  6. added doc block

    @jasells
    jasells committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    217e4f4 View commit details
    Browse the repository at this point in the history