Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only build ipc transport on *nix systems #185

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Jan 15, 2024

Hey all! I'm hoping to get a zeromq backed Tauri app to build on all systems. See nteract/nteract-next#16 for the app and the current PR.

I've added in a check for both the ipc-transport feature flag and checking that the platform is a *nix system. Let me know if there's a better approach for this.

Copy link
Collaborator

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mmastrac mmastrac merged commit 28ac4a4 into master Jan 15, 2024
2 of 3 checks passed
@rgbkrk rgbkrk deleted the only-build-ipc-on-nix branch January 15, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants