Ported code to use futures_codec and tokio_util's Compat #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
changed the title
TheButlah
changed the title
|
OK, using criterion's CLI, I ran a benchmark for both master and for this PR. both were run with a warm up time of 120 and a measurement time of 60 seconds. Saving both results and comparing the two, here's what I get: I trust these results, the measurement and warm ups were long enough and my clock speeds stayed the same in both after the warm up period. So it looks like we have a 3.4% performance regression. Personally I think that's totally fine given the benefits since we can probably optimize stuff later, but what do you think @Alexei-Kornienko? |
|
LGTM. I don't see any noticeable regression on my PC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR is a smaller change than #77, which avoids any dynamic dispatch or boxing. It is intended to isolate the changes to just that what is necessary to use
futures_codecandtokio_util::compatinstead oftokio_util::codec.Don't merge this MR - we need to merge some basic performance benchmarks to master first,and then we can see the performance impact of the codec changes, separately from the dynamic dispatch stuff in #77.