Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes in sisl.viz #619

Merged
merged 3 commits into from
Sep 30, 2023
Merged

Some fixes in sisl.viz #619

merged 3 commits into from
Sep 30, 2023

Conversation

pfebrer
Copy link
Contributor

@pfebrer pfebrer commented Sep 29, 2023

  • There was a bug for selecting spin contributions where you couldn't ask for spin 0 or 1 in spin polarized data.
  • Added plot index as metadata of traces for merged plots (in plotly), so that the traces from one childplot can easily be target.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (623eec8) 87.27% compared to head (898e76c) 87.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
- Coverage   87.27%   87.25%   -0.02%     
==========================================
  Files         355      355              
  Lines       47680    47719      +39     
==========================================
+ Hits        41611    41638      +27     
- Misses       6069     6081      +12     
Files Coverage Δ
src/sisl/viz/plots/merged.py 71.42% <ø> (ø)
src/sisl/viz/processors/tests/test_orbital.py 99.29% <100.00%> (+0.03%) ⬆️
src/sisl/viz/processors/xarray.py 73.78% <100.00%> (+1.33%) ⬆️
src/sisl/viz/processors/orbital.py 89.09% <86.20%> (+2.37%) ⬆️
src/sisl/viz/figure/plotly.py 25.51% <5.00%> (-1.60%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

break
except TypeError:
# selected is a scalar
...

Check notice

Code scanning / CodeQL

Statement has no effect Note

This statement has no effect.
@zerothi zerothi merged commit a20125c into zerothi:main Sep 30, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants