Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing many simple PEP-585 deprecations #818

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fixing many simple PEP-585 deprecations #818

merged 1 commit into from
Aug 8, 2024

Conversation

zerothi
Copy link
Owner

@zerothi zerothi commented Aug 8, 2024

This means moving from typing to intrinsics.

Many of the collections types are still not in-place.

  • Added tests for new/changed functions?
  • Ran isort . and black . [24.2.0] at top-level
  • Documentation for functionality in docs/
  • Changes documented in CHANGELOG.md

@@ -7,7 +7,7 @@

import sisl

from .file_source import FileData
from .file_source import FileData # noqa: F401

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'FileData' is not used.
This means moving from typing to intrinsics.

Many of the collections types are still not in-place.

Signed-off-by: Nick Papior <[email protected]>
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 97.91667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.67%. Comparing base (2334f69) to head (2c5e221).

Files Patch % Lines
src/sisl/physics/_ufuncs_matrix.py 0.00% 2 Missing ⚠️
src/sisl/_lazy_viz.py 0.00% 1 Missing ⚠️
src/sisl/_nodify.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
- Coverage   86.70%   86.67%   -0.04%     
==========================================
  Files         400      400              
  Lines       51868    51722     -146     
==========================================
- Hits        44974    44831     -143     
+ Misses       6894     6891       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zerothi zerothi merged commit a64d17f into main Aug 8, 2024
8 of 17 checks passed
@zerothi zerothi deleted the pep-585-fixes branch August 8, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant