-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modify rpc methods to include synthetic txs #2282
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11033145 | Triggered | Generic High Entropy Secret | 7dd8aa6 | cmd/zetae2e/local/accounts.go | View secret |
11033146 | Triggered | Generic High Entropy Secret | 7dd8aa6 | cmd/zetae2e/local/accounts.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2282 +/- ##
========================================
Coverage 69.25% 69.26%
========================================
Files 274 274
Lines 16535 16537 +2
========================================
+ Hits 11452 11454 +2
Misses 4599 4599
Partials 484 484
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good , wondering if there is a separate task any plans to add add unit tests for some of the functions added or modified ?
|
Description
This PR introduces changes in rpc methods to support synthetic ethermint txs (txs of type 88, where ethermint state is changed by directly calling ApplyMessage method from zetacore).
Some details:
EthMsgsFromTendermintBlock method is modified to include all txs, both regular ethermint and synthetic.
This enabled simple implementation of following methods:
Regarding other tx info methods:
eth_getTransactionByHash
eth_getTransactionReceipt
If its regular ethermint tx, it can be decoded from tx. If it's not, recreate it from additional tx fields.
Regarding block methods it seems they can remain the same.
Closes: 1959
Type of change
How Has This Been Tested?
Smoke tests done for athens3 and local txs, more testing in next PR (#2282) : move unit tests from ethermint fork here and extend them for these modifications.
Checklist: