feat: cosmos v0.50 upgrade

[skosito]

Description

Upgrades cosmos to v50.
Ethermint side: zeta-chain/ethermint#179

Closes:

• Upgrade Cosmos SDK to v0.50 #3219
• /cosmos/consensus/v1/params is missing from the swagger api docs #3296

Note: mockery is broken for authority module as it can't mock inline interface for sdk.Msg

Also need to check if changes in simulation tests are working.

Some parts like server/start.go should be reviewed in more details to ensure something is not missing.

How Has This Been Tested?

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

[coderabbitai]

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

198 files out of 282 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 79.41176% with 35 lines in your changes missing coverage. Please review.

Project coverage is 63.01%. Comparing base (9e57a3f) to head (aa1babe).
Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
precompiles/staking/method_get_shares.go	0.00%	6 Missing ⚠️
precompiles/staking/method_stake.go	0.00%	6 Missing ⚠️
pkg/mempool/custom_proposal_handler.go	58.33%	5 Missing ⚠️
precompiles/staking/method_move_stake.go	0.00%	5 Missing ⚠️
precompiles/staking/method_unstake.go	0.00%	5 Missing ⚠️
precompiles/staking/method_get_all_validators.go	25.00%	2 Missing and 1 partial ⚠️
x/authority/keeper/authorization_list.go	50.00%	2 Missing and 1 partial ⚠️
x/crosschain/migrations/v2/migrate.go	0.00%	1 Missing ⚠️
x/observer/keeper/hooks.go	96.55%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3357      +/-   ##
===========================================
- Coverage    63.03%   63.01%   -0.02%     
===========================================
  Files          436      436              
  Lines        30660    30683      +23     
===========================================
+ Hits         19325    19336      +11     
- Misses       10525    10535      +10     
- Partials       810      812       +2     

Files with missing lines	Coverage Δ
pkg/coin/coin.go	100.00% <100.00%> (ø)
pkg/gas/gas_limits.go	100.00% <100.00%> (ø)
pkg/rpc/clients.go	69.44% <100.00%> (ø)
pkg/rpc/clients_cosmos.go	62.50% <ø> (ø)
pkg/rpc/clients_tendermint.go	62.50% <100.00%> (ø)
precompiles/bank/bank.go	77.89% <100.00%> (+0.23%)	⬆️
precompiles/precompiles.go	20.68% <ø> (ø)
precompiles/prototype/prototype.go	69.03% <ø> (ø)
precompiles/staking/method_get_rewards.go	39.68% <100.00%> (ø)
precompiles/staking/staking.go	72.27% <100.00%> (+0.13%)	⬆️
... and 59 more

... and 10 files with indirect coverage changes

[lumtis]

I was initially expected sdk.Context to be replaced by context.Context everywhere but this is finally not needed?

[skosito]

I was initially expected sdk.Context to be replaced by context.Context everywhere but this is finally not needed?

it seems to be replaced in cosmos-sdk modules, but when code interacts with it (eg. in hooks) it can unwrap sdk.Ctx from context.Context

we can also refactor our modules i guess, but seems out of scope

[lumtis]

it seems to be replaced in cosmos-sdk modules, but when code interacts with it (eg. in hooks) it can unwrap sdk.Ctx from context.Context

we can also refactor our modules i guess, but seems out of scope

Ok, let's keep it less complex

[gartnera]

Nothing looks too crazy in this PR. I think we should move to get it merged as fast as possible to avoid conflicts.

We do need to get the ethermint integration tests running before the next release.

[lumtis]

Nothing looks too crazy in this PR. I think we should move to get it merged as fast as possible to avoid conflicts.

We do need to get the ethermint integration tests running before the next release.

Agree on this