Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade attest-build-provenance #3376

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Jan 17, 2025

https://github.com/actions/attest-build-provenance/releases

The attest-build-provenance action now supports attesting multiple subjects simultaneously.

This should make the offline/private verification process actually work:

gh attestation verify --owner zeta-chain -b attestation.json zetacored-linux-amd64
Loaded digest sha256:d47473b9c63613a2f7aa7aaa991cfac8d73d5ae335a4110dcc1c21db0a140df1 for file://zetacored-linux-amd64
Loaded 1 attestation from attestation.json

The following policy criteria will be enforced:
- OIDC Issuer must match:................... https://token.actions.githubusercontent.com
- Source Repository Owner URI must match:... https://github.com/zeta-chain
- Predicate type must match:................ https://slsa.dev/provenance/v1
- Subject Alternative Name must match regex: (?i)^https://github.com/zeta-chain/

✓ Verification succeeded!

sha256:d47473b9c63613a2f7aa7aaa991cfac8d73d5ae335a4110dcc1c21db0a140df1 was attested by:
REPO                     PREDICATE_TYPE                  WORKFLOW
zeta-chain/node-private  https://slsa.dev/provenance/v1  .github/workflows/publish-release.yml@refs/heads/release/v0

I will need to upgrade noderelease2proposal to tolerate the individual json rather than the jsonl.

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow to use the latest version of the artifact attestation action.

@gartnera gartnera added the no-changelog Skip changelog CI check label Jan 17, 2025
Copy link
Contributor

coderabbitai bot commented Jan 17, 2025

📝 Walkthrough

Walkthrough

The pull request introduces a version update for the actions/attest-build-provenance action from v1 to v2 in the GitHub Actions workflow file for publishing releases. This modification targets the artifact attestation step within the publish-release job, potentially incorporating new features or improvements in the action's functionality while maintaining the existing workflow structure.

Changes

File Change Summary
.github/workflows/publish-release.yml Updated GitHub Actions workflow to use actions/attest-build-provenance@v2 instead of @v1

Possibly related PRs

Suggested reviewers

  • fbac
  • skosito
  • kingpinXD
  • ws4charlie
  • brewmaster012
  • lumtis
  • swift1337

Note: No sequence diagram is generated for this change as it represents a simple version update to a GitHub Actions workflow action.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4bdfc0b and a4e0f0a.

📒 Files selected for processing (1)
  • .github/workflows/publish-release.yml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/publish-release.yml
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: start-e2e-test / e2e

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Jan 17, 2025
@gartnera gartnera marked this pull request as ready for review January 17, 2025 18:14
@gartnera gartnera requested a review from a team as a code owner January 17, 2025 18:14
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gartnera gartnera added this pull request to the merge queue Jan 20, 2025
Merged via the queue into develop with commit 078dbef Jan 20, 2025
44 of 49 checks passed
@gartnera gartnera deleted the upgrade-attest-build-provenance branch January 20, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions no-changelog Skip changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants