Respect Exchange.skipRpcConfirmation everywhere (#384)

zetamarkets · Apr 15, 2024 · 1a81047 · 1a81047
1 parent 52ef1c2
commit 1a81047
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 15 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 Version changes are pinned to SDK releases.
 
+## [1.26.4]
+
+- Respect Exchange.skipRpcConfirmation everywhere. ([#384](https://github.com/zetamarkets/sdk/pull/384))
+
 ## [1.26.3]
 
 - Add crank market generation util. ([#383](https://github.com/zetamarkets/sdk/pull/383))

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@zetamarkets/sdk",
   "repository": "https://github.com/zetamarkets/sdk/",
-  "version": "1.26.3",
+  "version": "1.26.4",
   "description": "Zeta SDK",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/src/exchange.ts b/src/exchange.ts
@@ -1125,17 +1125,7 @@ export class Exchange {
     try {
       await Promise.all(
         txs.map(async (tx) => {
-          let txSig = await utils.processTransaction(
-            this._provider,
-            tx,
-            undefined,
-            undefined,
-            undefined,
-            undefined,
-            undefined,
-            undefined,
-            this.skipRpcConfirmation
-          );
+          let txSig = await utils.processTransaction(this._provider, tx);
           console.log(`[REBALANCE INSURANCE VAULT]: ${txSig}`);
         })
       );

diff --git a/src/utils.ts b/src/utils.ts
@@ -958,8 +958,7 @@ export async function processTransaction(
   useLedger: boolean = false,
   lutAccs?: AddressLookupTableAccount[],
   blockhash?: { blockhash: string; lastValidBlockHeight: number },
-  retries?: number,
-  skipConfirmation?: boolean
+  retries?: number
 ): Promise<TransactionSignature> {
   let failures = 0;
   while (true) {
@@ -1042,7 +1041,7 @@ export async function processTransaction(
       // Poll the tx confirmation for N seconds
       // Polling is more reliable than websockets using confirmTransaction()
       let currentBlockHeight = 0;
-      if (!skipConfirmation) {
+      if (!Exchange.skipRpcConfirmation) {
         while (currentBlockHeight < recentBlockhash.lastValidBlockHeight) {
           // Keep resending to maximise the chance of confirmation
           await provider.connection.sendRawTransaction(rawTx, {