Adding support for duc json
#294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MYDIH
commented
Jul 19, 2022
| while(*s) { | ||
| switch(*s) { | ||
| case '"': printf("\""); break; | ||
| case '\t': putchar('\t'); break; |
There was a problem hiding this comment.
I wasn't really sure this was mandatory ...
MYDIH
commented
Jul 19, 2022
| if(e->type == DUC_FILE_TYPE_DIR && size>= min_size) { | ||
| duc_dir *dir_child = duc_dir_openent(dir, e); | ||
| if(dir_child) { | ||
| indent(depth); |
There was a problem hiding this comment.
At first, I tried to add a new method to merge the root print and the children prints. It was really painful due to commas, in the end I added a boolean to handle those. Thoughts welcome !
|
This is nice, no particular comments on the code or your comments (the bool comma handling is idiomatic, just fine). I'mma merge this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
I would like to have an interactive sunburst graph on one of my websites. I was going to translate XML to JSON (way easier to manipulate IMHO), and then I saw this Feature Request. I didn't add any tests though, I'm not really sure how to test this properly and I didn't find a test of the XML version to take inspiration from ... The tests harness is failing on my side too, seems like the size and md5 changed maybe ?
Anyway, cool project to work on !