chore: optimize catch error login in vue3

zhangyuang · Sep 21, 2024 · 12dcd8a · 12dcd8a
1 parent 450d4ed
commit 12dcd8a
Showing 1 changed file with 3 additions and 12 deletions.
diff --git a/packages/plugin-vue3/src/entry/server-entry.ts b/packages/plugin-vue3/src/entry/server-entry.ts
@@ -147,7 +147,6 @@ const serverRender = async (ctx: ISSRContext, config: IConfig) => {
     }
 
     const state = Object.assign({}, store.state ?? {}, asyncData.value)
-    let err: any = null
     const app = getApp({
       state,
       asyncData,
@@ -161,9 +160,8 @@ const serverRender = async (ctx: ISSRContext, config: IConfig) => {
       inlineJsOrder,
       rootId
     })
-    if (!app.config.errorHandler) {
-      app.config.errorHandler = e => { err = e }
-    }
+
+    app.config.errorHandler = app.config.errorHandler ?? (e => { throw e })
     app.use(router)
     app.use(store)
     app.use(pinia)
@@ -172,19 +170,12 @@ const serverRender = async (ctx: ISSRContext, config: IConfig) => {
       app
     }, async () => {
       if (stream) {
-        const stream = renderToNodeStream(app)
-        if (err) {
-          throw err
-        }
-        return stream
+        return renderToNodeStream(app)
       } else {
         const teleportsContext: {
           teleports?: Record<string, string>
         } = {}
         const html = await renderToString(app, teleportsContext)
-        if (err) {
-          throw err
-        }
         return ({
           html,
           teleportsContext