Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: serialize message #152

Merged
merged 6 commits into from
Oct 4, 2024
Merged

Refactoring: serialize message #152

merged 6 commits into from
Oct 4, 2024

Conversation

ybensacq
Copy link
Contributor

@ybensacq ybensacq commented Oct 2, 2024 •
edited
Loading

  1. refactoring serialize function
  2. add missing generic checksum
  3. refactoring deserializeSlice function

tdelabro
tdelabro reviewed Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@tdelabro tdelabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deserializeSlice can also be made generic

@tdelabro
Copy link
Collaborator

tdelabro commented Oct 2, 2024

or removed, if it's never used .... But I think it's used for tests

@tdelabro tdelabro merged commit bf53548 into zig-bitcoin:main Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdelabro tdelabro tdelabro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ybensacq @tdelabro