Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌸 DesignLibrary: CardComponent #2110

Open
Tracked by #1187
zspencer opened this issue Jan 11, 2024 · 0 comments
Open
Tracked by #1187

🌸 DesignLibrary: CardComponent #2110

zspencer opened this issue Jan 11, 2024 · 0 comments

Comments

@zspencer
Copy link
Member

zspencer commented Jan 11, 2024 •
edited
Loading

@zspencer zspencer mentioned this issue Jan 11, 2024
Open
12 tasks
@zspencer zspencer changed the title 🥔 Card 🥔 DesignLibrary: Card Jan 11, 2024
@zspencer zspencer changed the title 🥔 DesignLibrary: Card 🥔 DesignLibrary: CardComponent Jan 11, 2024
zspencer added a commit that referenced this issue Jan 11, 2024
@zspencer
✨CardComponent: Has a Header Slot
d96c935 
- #2110

This is perhaps unnecessary; since `<header>` tags are easy to write;
but maybe it's actually useful?
@zspencer zspencer mentioned this issue Jan 13, 2024
Merged
zspencer added a commit that referenced this issue Jan 14, 2024
@zspencer
✨CardComponent: Has a Header Slot
c900386 
- #2110

This is perhaps unnecessary; since `<header>` tags are easy to write;
but maybe it's actually useful?
zspencer added a commit that referenced this issue Jan 21, 2024
@zspencer
✨CardComponent: Has a Header Slot (#2114)
85ffdf2 
* ✨`CardComponent`: Has a Header Slot

- #2110

This is perhaps unnecessary; since `<header>` tags are easy to write;
but maybe it's actually useful?

* 🌸🧹 `CardComponent`: Gray the Footer, pull Classes into HTML

* 🧹 `CardComponent`: Headers have a default style

OK so TIL about [ViewComponent Lambda
Slots](https://viewcomponent.org/guide/slots.html#lambda-slots), which
seem like a decent way for paramaterizing headers and footers.
overridden.

There are variants for the Header and Footer, which seems nice

It could be good to update the ComponentPreview as well...
zspencer added a commit that referenced this issue Jan 25, 2024
@zspencer
🌸 Components: Card does not need a gap-y
9c5b433 
- #2110

If we enforce a gap at the card level, it makes it hard to format things
nicely in contexts where there should not be a gap between the header
and footer.

The `justify-between` is "enough" to ensure that the footer sticks to
the bottom of the card, and the `header` and `footer` both provide
padding.

So no need to set that intention + enforce it multiple places; and this
place seemed like the one that was least tailorable to the immediate
usage context.
@zspencer zspencer mentioned this issue Jan 25, 2024
Merged
zspencer added a commit that referenced this issue Jan 25, 2024
@zspencer
🌸 Components: Card does not need a gap-y (#2148)
5e21740 
- #2110

If we enforce a gap at the card level, it makes it hard to format things
nicely in contexts where there should not be a gap between the header
and footer.

The `justify-between` is "enough" to ensure that the footer sticks to
the bottom of the card, and the `header` and `footer` both provide
padding.

So no need to set that intention + enforce it multiple places; and this
place seemed like the one that was least tailorable to the immediate
usage context.
@zspencer zspencer changed the title 🥔 DesignLibrary: CardComponent DesignLibrary: CardComponent Feb 17, 2024
@zspencer zspencer changed the title DesignLibrary: CardComponent 🌸 DesignLibrary: CardComponent Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zspencer