✨CardComponent: Has a Header Slot
#2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #2110 This is perhaps unnecessary; since `<header>` tags are easy to write; but maybe it's actually useful?
zspencer
force-pushed
the
card_component/has-a-header
branch
from
384ad63
to
4478814
Compare
OK so TIL about [ViewComponent Lambda Slots](https://viewcomponent.org/guide/slots.html#lambda-slots), which seem like a decent way for paramaterizing headers and footers. overridden. There are variants for the Header and Footer, which seems nice It could be good to update the ComponentPreview as well...
zspencer
force-pushed
the
card_component/has-a-header
branch
from
69e2d6e
to
d023edd
Compare
rosschapman
reviewed
Jan 20, 2024
| DEFAULT_FOOTER = "bg-slate-50 p-2 sm:p-4" | ||
| FOOTER_VARIANTS = { | ||
| default: DEFAULT_FOOTER, | ||
| action_bar: [DEFAULT_FOOTER, "flex flex-row justify-between"].join(" ") |
There was a problem hiding this comment.
Suggestion: create a separate ActionCardComponent -- with duplicate styling/code as necessary. I tend to dislike parameterizing layout or style unless it's related to component state. But that's because I've seen this type of parameterization grow unwieldy when a single component tries to handle too many use cases. We're not there yet, of course.
There was a problem hiding this comment.
Yea, I was thinking if we got to 3+ variants I would want to start pulling out the more special-purpose ones; and I feel like an ActionCardComponent is a pretty good next step when that happens!
rosschapman
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DesignLibrary:CardComponent#2110This is perhaps unnecessary; since
<header>tags are easy to write; but maybe it's actually useful?