Stripe: Sprout Initial Stripe Utility #1003
Conversation
#831 #1002 This is mostly because I want to be able to move forward with connecting Vendor and Distributor accounts in the Marketplace, and to get started fiddling with the Stripe Connect bits. This also hopefully helps set the stage to getting rid of `Utility` classes, and instead have those inherit fro `UtilityHookup` (kind of like how new `Furniture` inherits from `FurniturePlacement` To be honest, I should probably either do a rename pass to more clearly indicate the old-way vs now-and-forward way of defining furniture, or do a final cleanup pass on both of those before starting this, but this was the nearest-mess-to-muck-with ( not clean... just.. uhhh... muck with) Anyway!
zspencer
requested review from
anaulin,
KellyAH,
sadiejay,
naomiquinones and
a team
|
CI Failed, back-to-draft with ye. Thoughts on the trajectory v much welcome. |
|
This is an intermediary step to at least get the Stripe API Token settable; but I pulled back from refactoring the Utilities structure. I'm going to try and finish unfucking the Furniture structure(s) before I start unfucking Utility. |
|
I'm not entirely sure, tbh. I think we have open questions about whether the Stripe API Key wants to live in the Marketplace, or at the Space level. Storing it at the Marketplace for now is probably the straightest path towards a working feature; but having the Utility available/merged in could be useful for when a Space has many Marketplaces. |
| @@ -9,9 +9,10 @@ class UtilityHookup < ApplicationRecord | |||
| # has multiple {UtilityHookup}s. | |||
| # @return [String] | |||
| attribute :name, :string | |||
| validates :name, presence: :true, uniqueness: { scope: :space_id } | |||
There was a problem hiding this comment.
This is ok for now, but I can imagine wanting to have more than one Stripe account associated with a space in the future. But maybe the hookup itself will support multiple API keys. We'll cross that bridge when we get to it.
There was a problem hiding this comment.
This is validating the name given to the utility to disambiguate it against different utilities on the same space. I.e. Stripe Account - Jim's Beans vs Stripe Account - Jane's Jams
Maybe we should rename the field to label? Does that feel more clear than name?
There was a problem hiding this comment.
Oh 🤦🏼♀️ Bad code reviewer, no donut for me.
#831 #1002
This is mostly because I want to be able to move forward with connecting Vendor and Distributor accounts in the Marketplace, and to get started fiddling with the Stripe Connect bits.
This also hopefully helps set the stage to getting rid of
Utilityclasses, and instead have those inherit froUtilityHookup(kind of like how newFurnitureinherits fromFurniturePlacementTo be honest, I should probably either do a rename pass to more clearly indicate the old-way vs now-and-forward way of defining furniture, or do a final cleanup pass on both of those before starting this, but this was the nearest-mess-to-muck-with ( not clean... just.. uhhh... muck with)
Anyway!