Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Furniture: Marketplace #761

Closed
wants to merge 6 commits into from
Closed

Furniture: Marketplace #761

wants to merge 6 commits into from

Conversation

zspencer
Copy link
Member

@zspencer zspencer commented Jul 24, 2022

#831

  • Tidying
    • Pull everything that isn't specifically about the Marketplace Furniture into tiny PRs that can be merged independently.
      • FurnitureController changes
      • money gem
      • button CSS specificity fixes
      • email_field partial
  • Sketch Checkout flow
  • Rename Marketplace::Item to Marketplace::LineItem
  • Persist the Marketplace::Order
  • Persist Marketplace::LineItems in the Marketplace::Order?

Maybe?

  • Sprout Marketplace::Stall for segmenting Marketplace::Product based upon who is selling?

| Delivery by Piikup | 1 | $6.99 |
- Then the Guest is charged $20.54 for their Marketplace Order
- And the Marketplace Vendor "Piikup" receives the Marketplace Order placed by the Guest in the "Piikup Marketplace" Space
- And the Marketplace Vendor "Piikup" receives a Payment of $6.99
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want Piikup to be a Marketplace Vendor; or if we want them to be the Stripe account holder. I think the latter?

I've been reading more about Stripe Connect (since I haven't implemented it yet) and I think we want to try and get it to work with Direct Charges, because that means we can add the delivery fee as an "application fee" rather than trying to separate the charges

This puts the payment directly into the Stripe account of the seller, less the stripe platform fees (2.9% + .50c?) and the Application Fee; and makes the seller responsible for refunds, etc; which seems like the lightest weight way to do this.

@zspencer zspencer marked this pull request as draft July 24, 2022 23:03
@zspencer zspencer changed the title Shift from a Delivery Order Form to a Marketplace Furniture: Marketplace Aug 25, 2022
This may not quite be what we're looking for just yet, but I'm trying to
make it more general purpose than the specific use case I started from.
@zspencer zspencer closed this Oct 6, 2022
@zspencer zspencer deleted the furniture/marketplace branch October 6, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant