chore: replace interface{} with any
#448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #448 +/- ##
=======================================
Coverage 53.96% 53.96%
=======================================
Files 74 74
Lines 5830 5830
=======================================
Hits 3146 3146
Misses 2424 2424
Partials 260 260
|
muhlemmer
requested changes
Oct 12, 2023
There was a problem hiding this comment.
Hi. Thanks for housekeeping. There are some files that you changed in the PR, which are generated. These changes will be undone the next time go generate ./... is run. I've commented on the files, these should not be part of the PR.
As a practice, generated files should never be changed manually. This is also mentioned at the top of every generated file:
// Code generated by xxxx. DO NOT EDIT.
Signed-off-by: Thomas Hipp <[email protected]>
Signed-off-by: Thomas Hipp <[email protected]>
Signed-off-by: Thomas Hipp <[email protected]>
Signed-off-by: Thomas Hipp <[email protected]>
Signed-off-by: Thomas Hipp <[email protected]>
Signed-off-by: Thomas Hipp <[email protected]>
muhlemmer
changed the title
interface{} with anyinterface{} with any
monstermunchkin
force-pushed
the
misc/any-interface
branch
from
a9db523 to
e948bed
Compare
muhlemmer
approved these changes
Oct 12, 2023
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a mixed use of
interface{}andany. This PR replaces all occurances ofinterface{}withanyto be consistent and improve readability.Definition of Ready