Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op): return state in token response only for implicit flow #460

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

muhlemmer
Copy link
Collaborator

@muhlemmer muhlemmer commented Oct 13, 2023

Return state as part of the token response only for implicit flow. For code flow the state should not be returned as part of the token response.

Closes #446

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #460 (76b36cf) into main (976b406) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   60.33%   60.30%   -0.04%     
==========================================
  Files          78       78              
  Lines        6696     6698       +2     
==========================================
- Hits         4040     4039       -1     
- Misses       2367     2369       +2     
- Partials      289      290       +1     
Files Coverage Δ
pkg/op/token.go 68.57% <0.00%> (-1.38%) ⬇️

@muhlemmer muhlemmer marked this pull request as ready for review October 13, 2023 12:12
@muhlemmer muhlemmer requested a review from livio-a October 13, 2023 12:12
livio-a
livio-a previously approved these changes Oct 13, 2023
@livio-a livio-a enabled auto-merge (squash) October 13, 2023 12:15
@livio-a livio-a disabled auto-merge October 13, 2023 12:15
@livio-a livio-a enabled auto-merge (squash) October 13, 2023 12:16
@livio-a livio-a merged commit 0dc2a6e into main Oct 13, 2023
@livio-a livio-a deleted the fix-state-codeflow branch October 13, 2023 12:17
@github-actions
Copy link

🎉 This PR is included in version 3.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

wdantuma pushed a commit to wdantuma/solid-oidc that referenced this pull request Jan 31, 2024
…el#460)

* fix(op): return state in token response only for implicit flow

* oops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

state always returned in access token response
2 participants