Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op): terminate session from request in legacy server #465

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

muhlemmer
Copy link
Collaborator

@muhlemmer muhlemmer commented Oct 23, 2023

This change adds the CanTerminateSessionFromRequest interface to the LegecyServer TerminateSession method. The optional interface was added to the v2 OP while v3 was still in the making. Therefore it was missed .

Related zitadel/zitadel#6619

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #465 (28be9d8) into main (434b2e6) will decrease coverage by 0.02%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
- Coverage   60.30%   60.28%   -0.02%     
==========================================
  Files          78       78              
  Lines        6698     6703       +5     
==========================================
+ Hits         4039     4041       +2     
- Misses       2369     2370       +1     
- Partials      290      292       +2     
Files Coverage Δ
pkg/op/server_legacy.go 44.78% <57.14%> (-0.10%) ⬇️

@muhlemmer muhlemmer requested a review from livio-a October 23, 2023 14:14
@muhlemmer muhlemmer merged commit 164c5b2 into main Oct 24, 2023
@muhlemmer muhlemmer deleted the fix-endsession-request branch October 24, 2023 07:17
@github-actions
Copy link

🎉 This PR is included in version 3.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants