Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op): export NewProvider to allow customized issuer #479

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

muhlemmer
Copy link
Collaborator

#478 allows to customize header used for the issuer host. However, it did not provide means to expose this options to the provider constructor..

This change exports NewPriovider so that the issuer function can be passed directly and therefore be customized.
It also deprecates the other constructors as they became redundant.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@muhlemmer muhlemmer requested a review from livio-a November 10, 2023 13:34
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #479 (7a7e593) into main (7475023) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #479   +/-   ##
=======================================
  Coverage   60.29%   60.29%           
=======================================
  Files          78       78           
  Lines        6753     6753           
=======================================
  Hits         4072     4072           
  Misses       2385     2385           
  Partials      296      296           
Files Coverage Δ
pkg/op/op.go 69.84% <50.00%> (ø)

@livio-a livio-a merged commit d88c0ac into main Nov 10, 2023
7 of 8 checks passed
@livio-a livio-a deleted the fix-newprovider branch November 10, 2023 14:26
Copy link

🎉 This PR is included in version 3.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants