fix: allow native applications to use https:// on loopback redirect addresses #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conblem
commented
Dec 17, 2024
| if client.ApplicationType() == ApplicationTypeNative { | ||
| return validateAuthReqRedirectURINative(client, uri) | ||
| } | ||
| if strings.HasPrefix(uri, "https://") { |
There was a problem hiding this comment.
previously URI's like https://registered/callback got handled by this but now validateAuthReqRedirectURINative takes precedence
conblem
commented
Dec 17, 2024
| if err := checkURIAgainstRedirects(client, uri); err == nil { | ||
| if client.DevMode() { | ||
| return nil | ||
| } | ||
| // The RedirectURIs are only valid for native clients when localhost or non-"http://" | ||
| if !isLoopback && strings.HasPrefix(uri, "https://") { |
There was a problem hiding this comment.
To still support URI's like https://registered/callback this condition had to be added. Im not 100% happy with the code tho
There was a problem hiding this comment.
Why do we need to support https://registered/callback on a non-loopback address? Native clients only run on the localhost, right? I also do not see that use case in the linked issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue where native clients were unable to utilize HTTPS for redirects on loopback addresses.
Changes Made:
Part of this: zitadel/zitadel#4091