fix: Non-enabled state triggers rendering

zjxxxxxxxxx · Dec 7, 2024 · f728a1f · f728a1f
1 parent 345fa6b
commit f728a1f
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/.changeset/empty-cherries-pay.md b/.changeset/empty-cherries-pay.md
@@ -0,0 +1,5 @@
+---
+'@open-editor/client': patch
+---
+
+Fix for non-enabled state triggering rendering
diff --git a/packages/client/src/bridge/boxModelBridge.ts b/packages/client/src/bridge/boxModelBridge.ts
@@ -2,12 +2,15 @@ import { crossIframeBridge } from '../utils/crossIframeBridge';
 import { isTopWindow, whenTopWindow } from '../utils/topWindow';
 import { onMessage, postMessage } from '../utils/message';
 import { type BoxLines, type BoxRect, getBoxModel } from '../inspector/getBoxModel';
+import { inspectorState } from '../inspector/inspectorState';
 import { BOX_MODEL_CROSS_IFRAME } from '../constants';
 
 export const boxModelBridge = crossIframeBridge<[BoxRect, BoxLines]>({
   setup() {
     onMessage<[BoxRect, BoxLines]>(BOX_MODEL_CROSS_IFRAME, (args) => {
-      boxModelBridge.emit(args, isTopWindow);
+      if (inspectorState.isEnable) {
+        boxModelBridge.emit(args, isTopWindow);
+      }
     });
   },
   emitMiddlewares: [

diff --git a/packages/client/src/bridge/codeSourceBridge.ts b/packages/client/src/bridge/codeSourceBridge.ts
@@ -1,13 +1,16 @@
 import { crossIframeBridge } from '../utils/crossIframeBridge';
 import { topWindow, whenTopWindow } from '../utils/topWindow';
 import { onMessage, postMessage } from '../utils/message';
+import { inspectorState } from '../inspector/inspectorState';
 import { type CodeSource } from '../resolve';
 import { CODE_SOURCE_CROSS_IFRAME } from '../constants';
 
 export const codeSourceBridge = crossIframeBridge<[CodeSource | undefined]>({
   setup() {
     onMessage<[CodeSource | undefined]>(CODE_SOURCE_CROSS_IFRAME, (args) => {
-      codeSourceBridge.emit(args, true);
+      if (inspectorState.isEnable) {
+        codeSourceBridge.emit(args, true);
+      }
     });
   },
   emitMiddlewares: [