Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update github action to check simd_backend and add cfg_doc for nightly #14

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

delta1
Copy link

@delta1 delta1 commented Sep 29, 2021

Hi @hdevalence,

This PR adds feature(doc_cfg) for the nightly feature and also adds the rustflags env for the github action to test simd_backend ( from the good suggestion in #5 )

I stumbled across an issue when trying to compile with simd_backend enabled by running:

RUSTFLAGS='-C target-feature=+avx2' cargo +nightly build --features simd_backend

The error was:

error[E0658]: `#[doc(cfg)]` is experimental
  --> src/backend/vector/mod.rs:21:1
   |
21 | #[doc(cfg(all(target_feature = "avx2", not(target_feature = "avx512ifma"))))]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #43781 <https://github.com/rust-lang/rust/issues/43781> for more information
   = help: add `#![feature(doc_cfg)]` to the crate attributes to enable

error[E0658]: `#[doc(cfg)]` is experimental
  --> src/backend/mod.rs:57:5
   |
57 | /     doc(cfg(any(all(
58 | |         feature = "simd_backend",
59 | |         any(target_feature = "avx2", target_feature = "avx512ifma")
60 | |     ))))
   | |________^
   |
   = note: see issue #43781 <https://github.com/rust-lang/rust/issues/43781> for more information
   = help: add `#![feature(doc_cfg)]` to the crate attributes to enable

Examples of the github action:

@delta1
Copy link
Author

delta1 commented Oct 14, 2021

hey @hdevalence hope you are well! Do you have any feedback here please?

Copy link
Collaborator

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the reminder :)

@hdevalence hdevalence merged commit bd189c1 into zkcrypto:main Oct 14, 2021
@hdevalence
Copy link
Collaborator

Published 4.1.1 with these changes.

@delta1
Copy link
Author

delta1 commented Oct 15, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants