forked from privacy-scaling-explorations/halo2
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rebase from upstream #8
Open
alexander-camuto
wants to merge
151
commits into
zkonduit:main
Choose a base branch
from
privacy-scaling-explorations:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: rebase from upstream #8
alexander-camuto
wants to merge
151
commits into
zkonduit:main
from
privacy-scaling-explorations:main
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: copy symbolic from Plonky3 * feat: copy fibo_air test from Plonky3 * feat: complete p3 frontend PoC * chore: clean up * chore: revert changes in middleware * fix: clippy warnings * feat: add keccak test and fixes - Bring back Rc instead of Box in SymbolicExpression so that expressions built with folding avoid many clones - Rewrite Expression doulbe as `e * 2` instead of `e + e` to avoid exponential cloning in expressions built with folding - When a constraint doesn't use a location, change it to use a selector for usable columns to avoid failing in poisoned rows * chore: clean up * fix: clippy warnings * chore: clean up tests * fix: clippy warnings * fix: remove debug print * chore: comment about transition constraints * chore: extend comment about PrimeField64 impl * fix: merge renamings * chore: add unit tests * fix: clippy complaints * chore: extend unit test * chore: replace no coverage directives * chore: remove no coverage directives * chore: apply feedback from @adria0 * fix: clippy warnings and PCS API update
- Pending coverage - Do not rely on random for tests - Move performance tests to specific test
fix: random point and scalar generation Also increased the size of the test MSM from k=4 to k=12.
* feat: remove "permutation_product_coset" from "Committed" * fix: update "h_commitments" part in "vanishing/prover.rs" * feat: remove the "Constructed" from permutation proving
* feat: include "shuffles" in "PinnedConstraintSystem::fmt" * chore: fix the "plonk_api" test
* patch: add multi-phase related challenge fields within transcript * chore: fix the "plonk_api" test * patch: add the Debug attribute
feat!: Use Vectors insead of slices for PI Instances were being passed as a triple slice of field elements: &[&[&[F]]] in many functions. It has been replaced for `&[Vec<Vec<F>>]`.
* feat: improve the "lookup_any" assertion checks * feat: add new feature "lookup-any-sanity-checks" * doc: add comments for new feature checks
* fix: make lookup-any-sanity-checks optional in halo2_proofs * fix: bad lookup tests only when feature
* bump halo2curves to 0.7 * fix: update compression tests * fix: update mycircuit, plonk_api and seride tests --------- Co-authored-by: kilic <[email protected]>
* feat: Faster computation of L0 refactor: parallelize denominator computation * feat: extended_lagrange function
* patch: use cell name in "Mockprover" assign functions * feat: introduce new "AssignmentError" enum * feat: use "AssignmentError" in "Mockprover" & "WitnessCollection" * doc: update comments for "AssignmentError"
* chore: add unit test for TracingFloorPlanner * chore: add unit test for "CircuitGates" * chore: add some test for "failure" mod * chore: add unit tests for "Expression*" * chore: improve unit tests for "frontend/dev/cost" * chore: improve unit tests for "frontend/dev/failure" * fix: improve the "serialization" example * feat: add 2 examples for serialization and circuit cost
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.22.7 to 1.24.6. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.22.7...v1.24.6) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add "WitnessMissing" variant to "AssignmentError" * feat: rename "AssignmentError" as "AssignError"
* feat: refactor the verification api * feat: rename the "verify_*" apis * feat: remove "Output" type from "VerificationStrategy" trait * feat: rename "ProverSingle" -> "Prover", "Prover" -> "ProverMulti"
* feat: split the "create_proof" logic into smaller functions --------- Co-authored-by: David Nevado <[email protected]>
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.24.6 to 1.26.0. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.24.6...v1.26.0) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#370) evaluation: fix the wrong eval_data of input_evaluator in shuffle
* feat: update "QueryBack", to use "ColumnMid" * fix: use "ArgumentMid" in "permutation" module * feat: move truncation out of "EvaluationDomain::extended_to_coeff" * chore: update test vectors
* Remove IPA base * No longer commitments to instance in transcript. * Remove binding from powerquery, fix docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.