Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reviung34 shield definition #1935

Merged
merged 16 commits into from
Oct 15, 2023
Merged

Reviung34 shield definition #1935

merged 16 commits into from
Oct 15, 2023

Conversation

alexkang
Copy link
Contributor

Board/Shield Check-list

  • [y] This board/shield is tested working on real hardware
  • [y] Definitions follow the general style of other shields/boards upstream (Reference)
  • [y] .zmk.yml metadata file added
  • [y] Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • [y] General consistent formatting of DeviceTree files
  • [y] Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • [y] &pro_micro used in favor of &pro_micro_d/a if applicable
  • [n/a] If split, no name added for the right/peripheral half
  • [y] Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • [y] .conf file has optional extra features commented out
  • [y] Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

@alexkang
Copy link
Contributor Author

@caksoylar gentle ping! Addressed adding the matrix transforms to the default keymap.

caksoylar
caksoylar approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, noted one tiny nit.

app/boards/shields/reviung34/boards/nice_nano_v2.overlay Show resolved Hide resolved
@caksoylar caksoylar added the shields PRs and issues related to shields label Sep 25, 2023
alexkang and others added 11 commits October 1, 2023 17:32
@alexkang
Initial implementation of REVIUNG34 shield.
5d161d4
@alexkang
Add copyright information to files
57efa94
@alexkang
Updated Reviung34 keymap and fixed comment syntax
5899810
@alexkang
Added a README with instructions on how to enable the 1x2u layout.
f59b391
@alexkang
Add a default chosen matrix transform in the default keymap, alongsid…
1b20238 
…e a commented out version for the alternate layout.
@alexkang
Make indents consistent in REVIUNG34 nice_nano_v2.overlay
7413398
@alexkang
REVIUNG34 README formatting
6f886b7
@petejohanson @caksoylar @alexkang
feat: Add soft on/off support.
cfd81a9 
Initial work on a soft on/off support for ZMK. Triggering soft off
puts the device into deep sleep with only a specific GPIO pin
configured to wake the device, avoiding waking from other key
presses in the matrix like the normal deep sleep.

Co-authored-by: Cem Aksoylar <[email protected]>
@petejohanson @alexkang
feat(kscan): Add PM support to GPIO kscan drivers.
eeeaec0 
* Add PM device hook to the kscan direct & matrix drivers.
@petejohanson @alexkang
feat(behaviors): Add soft off behavior.
d376bf4 
* New soft-off behavior that can be used to force the device
  into  soft-off state with only certain configured wakeup
  devices.
@petejohanson @alexkang
feat(shields): Add soft-off to the nrf52840dk ZMK Uno
0caeb46 
* Use Button 1 for soft off on the nrf52840 when using the ZMK Uno
  shield.
petejohanson
petejohanson requested changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor tweak to the keymap nodes.

app/boards/shields/reviung34/reviung34.keymap Outdated Show resolved Hide resolved
@alexkang alexkang requested a review from a team as a code owner October 14, 2023 23:04
@alexkang
Copy link
Contributor Author

Whoops sorry, lemme resolve some of my messy workspace issues.

@alexkang
Copy link
Contributor Author

Whoops sorry, lemme resolve some of my messy workspace issues.

Ok done! Should be good to review again!

petejohanson
petejohanson approved these changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petejohanson petejohanson merged commit a9a53e6 into zmkfirmware:main Oct 15, 2023
25 checks passed
@petejohanson
Copy link
Contributor

Merged. In the future, if you've accidentally gotten some other feature PR included, it's preferred to do an interactive rebase and remove the offending commits, instead of appending a revert commit at the end.

Thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caksoylar caksoylar caksoylar approved these changes

@petejohanson petejohanson petejohanson approved these changes

Assignees
No one assigned
Labels
shields PRs and issues related to shields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexkang @petejohanson @caksoylar