Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Defer auto enabling of kscan sideband. #2407

Conversation

petejohanson
Copy link
Contributor

  • Now that device init of kscan sideband is in POST_KERNEL stage, use a separate SYS_INIT for auto enabling the device so processing of early/initial presses from referenced toggle mode kscan devices occurs at the proper time during init.

/cc @ReFil

@petejohanson petejohanson added bug Something isn't working core Core functionality/behavior of ZMK labels Aug 5, 2024
@petejohanson petejohanson self-assigned this Aug 5, 2024
@petejohanson petejohanson requested a review from a team as a code owner August 5, 2024 18:15
@petejohanson petejohanson force-pushed the core/kscan-sideband-auto-enable-deferred-to-application-level branch 3 times, most recently from 64132f0 to fce1c38 Compare August 5, 2024 18:43
@ReFil
Copy link
Contributor

ReFil commented Oct 5, 2024

Given this a test on a board with a toggle switch and direct kscan driver with toggle-mode and all seems to be working as expected

* Now that device init of kscan sideband is in POST_KERNEL stage,
  use a separate SYS_INIT for auto enabling the device so processing
  of early/initial presses from referenced toggle mode kscan devices
  occurs at the proper time during init.
@petejohanson petejohanson force-pushed the core/kscan-sideband-auto-enable-deferred-to-application-level branch from fce1c38 to 2e03038 Compare October 8, 2024 06:49
@petejohanson petejohanson merged commit 47a17c6 into zmkfirmware:main Oct 8, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Core functionality/behavior of ZMK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants