Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding simple versioning using GHA to ZMK #2464

Closed
wants to merge 1 commit into from

Conversation

Nick-Munnich
Copy link
Contributor

Adds a simple versioning system to ZMK using GHA.

Conventional commit messages are used to identify when a new tag should be created:

  • commits starting with !, having !: in their commit message, or having BREAKING CHANGE in the message for major
  • commits starting with feat for minor
  • commits starting with fix for patch

New tags are always accompanied by a release. SKIP VERSIONING in a commit message can be used to skip versioning for that commit.

@Nick-Munnich Nick-Munnich added the github_actions Pull requests that update Github_actions code label Sep 7, 2024
@Nick-Munnich Nick-Munnich requested a review from a team as a code owner September 7, 2024 09:01
@petejohanson
Copy link
Contributor

I think we'll really want to consider how we want to do this. I'm not sure we really want to commit to an automated semantic versioning scheme at this stage for ZMK or not.

If not, I've been really happy with the fairly simple https://github.com/googleapis/release-please we're using for zmk-studio-ts-client. More to ponder.

@Nick-Munnich
Copy link
Contributor Author

I like the discussion that this sprouted - the more I think about it, the more I favor the trunk approach raised by damselfly. I'd prefer some sort of automated system over a manual one, personally.

@Nick-Munnich
Copy link
Contributor Author

Closing as recent discussion concluded that this is not the approach we'll be using.

@Nick-Munnich Nick-Munnich deleted the versioning branch September 27, 2024 08:46
@Nick-Munnich Nick-Munnich mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants