fix: Fix kscan prop existence test in physical layouts #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this might be a problem with an older ZMK version and doesn't currently reproduce, sorry about the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently building with a chosen physical layout which has a kscan, but no chosen "shared" kscan fails. See example build and corresponding failing overlay.
I am guessing this is because
DT_INST_PROP_LENdoesn't work for phandle type properties, and we can useDT_INST_NODE_HAS_PROPinstead. (I haven't spent too much time looking into this, happy to change if there is a better check.)