test

zoj613 · Nov 18, 2024 · 3861352 · 3861352
1 parent cb91a0c
commit 3861352
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 1 deletion.
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
@@ -29,13 +29,41 @@ jobs:
         local-packages:
           - zarr.opam
 
+    env:
+      AWS_ACCESS_KEY_ID: minioadmin
+      AWS_SECRET_ACCESS_KEY: minioadmin
+
+    services:
+      minio:
+        image: fclairamb/minio-github-actions
+        ports:
+          - 9000:9000
+
     name: Ocaml version - ${{ matrix.ocaml-compiler }} - ${{ matrix.os }}
     steps:
       - name: checkout
         uses: actions/checkout@v4
         with:
           fetch-depth: 2
 
+      - name: Setup Minio
+        run: |
+          mkdir ~/.aws
+          echo '[default]' > ~/.aws/credentials
+          echo 'aws_access_key_id = minioadmin' >> ~/.aws/credentials
+          echo 'aws_secret_access_key = minioadmin' >> ~/.aws/credentials
+          pip3 install minio
+          python3 - <<'EOF'
+          from minio import Minio
+          minio = Minio(
+             'localhost:9000',
+             access_key='minioadmin',
+             secret_key='minioadmin',
+             secure=False
+          )
+          minio.make_bucket('test-bucket-lwt', location='us-east-1')
+          EOF
+
       - name: setup-ocaml
         uses: ocaml/setup-ocaml@v3
         with:
@@ -45,7 +73,7 @@ jobs:
         run: |
           opam install --deps-only --with-test --with-doc --yes zarr
           opam install bytesrw conf-zlib conf-zstd --yes
-          opam install lwt aws-s3-lwt --yes
+          opam install lwt tls-lwt aws-s3-lwt --yes
           opam exec -- dune build zarr zarr-sync zarr-lwt
       
       - name: setup ocaml-5-specific

diff --git a/Makefile b/Makefile
@@ -26,3 +26,8 @@ docs:
 .PHONY: view-docs
 view-docs: docs
 	chromium _build/default/_doc/_html/index.html 
+
+.PHONY: minio
+minio:
+	mkdir -p /tmp/minio/test-bucket-lwt
+	docker run --rm -it -p 9000:9000 -v /tmp/minio:/minio minio/minio:latest server /minio
diff --git a/zarr-lwt/test/test_lwt.ml b/zarr-lwt/test/test_lwt.ml
@@ -141,11 +141,18 @@ let _ =
         (Zarr.Storage.Not_a_filesystem_store fn)
         (fun () -> FilesystemStore.open_store fn);
 
+      (* ZipStore configuration *)
       let zpath = tmp_dir ^ ".zip" in
+      (* AmazonS3Store configuration *)
+      let region = Aws_s3.Region.minio ~port:9000 ~host:"localhost" ()
+      and bucket = "test-bucket-lwt"
+      and profile = "default" in
+
       Lwt_main.run @@ Lwt.join 
         [ZipStore.with_open `Read_write zpath (fun z -> test_storage (module ZipStore) z)
          (* test just opening the now exisitant archive created by the previous test. *)
         ;ZipStore.with_open `Read_only zpath (fun _ -> ZipStore.Deferred.return_unit)
+        ;AmazonS3Store.with_open ~region ~bucket ~profile (test_storage (module AmazonS3Store))
         ;test_storage (module MemoryStore) @@ MemoryStore.create ()
         ;test_storage (module FilesystemStore) s])
 ])