Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Background::Wait and exercise in test. #97

Merged
merged 1 commit into from
Dec 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## HEAD

- Fix: Internal error in `background.wait` introduced in 4.1.2 (https://github.com/zombocom/rundoc/pull/97)

## 4.1.2

- Fix: Background task name lookup is now lazy, this fixes a bug when using `:::>- pre.erb background.start(...)` (https://github.com/zombocom/rundoc/pull/95)
Expand Down
2 changes: 1 addition & 1 deletion lib/rundoc/code_command/background/wait.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ def initialize(name:, wait:, timeout: 5)
end

def background
@background ||= Rundoc::CodeCommand::Background::ProcessSpawn.find(name)
@background ||= Rundoc::CodeCommand::Background::ProcessSpawn.find(@name)
end

def to_md(env = {})
Expand Down
5 changes: 5 additions & 0 deletions test/rundoc/code_commands/background_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ def test_stdin_with_cat_echo
output = stdin_write.call
assert_equal("hello there" + $/, output)

Rundoc::CodeCommand::Background::Wait.new(
name: "cat",
wait: "hello"
).call

Rundoc::CodeCommand::Background::Log::Clear.new(
name: "cat"
).call
Expand Down
Loading