Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropping default ValueTask #49

Merged
merged 10 commits into from
Jan 26, 2024
Merged

Fix dropping default ValueTask #49

merged 10 commits into from
Jan 26, 2024

Commits on Jan 25, 2024

  1. Fix dropping default ValueTask

    @GerardSmit
    GerardSmit committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    47c8197 View commit details
    Browse the repository at this point in the history

  2. Don't drop default when there is a return type

    @GerardSmit
    GerardSmit committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    d42e8ab View commit details
    Browse the repository at this point in the history

  3. Validate namespace

    @GerardSmit
    GerardSmit committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    ff91d4d View commit details
    Browse the repository at this point in the history

  4. Drop object creation of ValueTask<T>

    @GerardSmit
    GerardSmit committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    c323716 View commit details
    Browse the repository at this point in the history

  5. Only test ValueTask.CompletedTask on .NET Core 

    ValueTask.CompletedTask is not available in .NET Framework
    @GerardSmit
    GerardSmit committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    2d2443b View commit details
    Browse the repository at this point in the history

  6. Renamed ShouldRemoveObjectCreation

    @GerardSmit
    GerardSmit committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    b5b698b View commit details
    Browse the repository at this point in the history

  7. Move string to a constant

    @GerardSmit
    GerardSmit committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    2e7c0cb View commit details
    Browse the repository at this point in the history

  8. Remove new ValueTask

    @GerardSmit
    GerardSmit committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    2a89966 View commit details
    Browse the repository at this point in the history

  9. Fix incorrect test

    @GerardSmit
    GerardSmit committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    6977d1d View commit details
    Browse the repository at this point in the history

  10. Fix broken test

    @GerardSmit
    GerardSmit committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    4607909 View commit details
    Browse the repository at this point in the history