Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check MANIFEST when PR is created #383

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

MichaelTimbert
Copy link

Purpose

Run 'make distcheck' in tests.
I followed what was done in "zonemaster/zonemaster-engine#903"
It's the same as "zonemaster/zonemaster-ldns#195"

Context

Fixes #199

How to test this PR

Make sure we don't interfere with the release process:

git clean -dfx   # Start out with a clean repository
perl Makefile.PL # Generate the top-level Makefile
make all         # Generate MO files and modules.txt
make distcheck   # Verify that distcheck doesn't report any missing or unrecognized files

Run the unit tests in the source directory:

make distcheck     # Make sure distcheck doesn't report any missing or unrecognized files
prove t/manifest.t # Verify the new test passes
touch new.file  # Create a file but don't add it to MANIFEST
prove t/manifest.t # Verify the new test fails
echo "new.file" >> MANIFEST.SKIP 
prove t/manifest.t # Verify the new test passes

Run the unit tests in the dist file:

make distcheck                               # Make sure your repo is clean
make dist                                    # Create the dist file
cpanm --test-only Zonemaster-CLI-*.tar.gz # Run the tests included in the dist file

@MichaelTimbert MichaelTimbert added the S-PRforIssue Status: There is a PR that is meant to resolve the issue label Aug 27, 2024
@MichaelTimbert MichaelTimbert added this to the v2024.2 milestone Aug 27, 2024
@MichaelTimbert MichaelTimbert linked an issue Aug 27, 2024 that may be closed by this pull request
matsduf
matsduf previously approved these changes Aug 29, 2024
tgreenx
tgreenx previously approved these changes Sep 4, 2024
@matsduf
Copy link
Contributor

matsduf commented Oct 11, 2024

@MichaelTimbert, please merge

@MichaelTimbert MichaelTimbert merged commit 72606c8 into zonemaster:develop Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-PRforIssue Status: There is a PR that is meant to resolve the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check MANIFEST when PR is created (CLI)
4 participants