Update Connectivity04 implementation #1393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgreenx
added
the
A-TestCase
tgreenx
requested review from
mattias-p,
matsduf,
marc-vanderwal and
MichaelTimbert
tgreenx
added
the
FA-MethodV2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR proposes an update to the implementation of Connectivity04 following a specification update.
Note that this is the first implementation to make use of MethodsV2.
Context
Test case specification update: zonemaster/zonemaster#1298
Test zones specification: zonemaster/zonemaster#1299
Changes
lib/Zonemaster/Engine/ASNLookup.pmlib/Zonemaster/Engine/Test/Connectivity.pmt/Test-connectivity04.tt/Test-connectivity04.dataHow to test this PR
Unit tests are updated (based on zonemaster/zonemaster#1299) and should pass.
Note that scenario ERROR-PREFIX-DATABASE-3 is currently disabled because since its query ends up blacklisted (no response), it causes subsequent queries to be blacklisted as well. I'll look for a workaround.