-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Romanian translations. #123
Added Romanian translations. #123
Conversation
Thank you for your contribution. According to the contributing policies of the zopefoundation organization you need to sign a contributor agreement before any non-trivial change can be merged. For details please consult the Contributing guidelines for zopefoundation projects. |
@MrTango Is your Romanian good enough to review these translations? |
Hi Micheal,I signed a contributing license for Plone in 2007. Will that do? Or do you want a new one just for Zope which uses Plone’s as I understand.Kind regards,Jean-Paul LadageOn 13 Aug 2024, at 07:08, Michael Howitz ***@***.***> wrote:
@MrTango Is your Romanian good enough to review these translations?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
@jladage When you sign a Zope contributor agreement, you will get a Member of the So I cannot answer your question. I'd suggest either to ask someone of the Plone Foundation or just sign a contributor agreement for Zope. |
@jladage You are now listed as |
@icemac nope, at least not if nobody is able to review the Romanian translations I created with deepl. |
@avoinea Would you like to help review this or ask someone else to? |
Translation fixes Co-authored-by: Alin Voinea <[email protected]>
Translation fixes Co-authored-by: Alin Voinea <[email protected]>
Translation fixes ro Co-authored-by: Alin Voinea <[email protected]>
Hi @avoinea, I merged your translation suggestions. Could you please review once more so I can merge? |
@icemac the test coverage is currently blocking this request from merging. I'm not familiar enough with the code to understand why. Do we test translations? Are our changes the result of the test coverage problem? |
@jladage The translations are not part of the coverage and are not tested. I saw a drop in coverage on serveral packages, probably because of a new version of the I'll merge this PR now and tackle the coverage problem later on. |
Just added translations for Romanian language.