fix: missing implementation of --exclude #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42
This does the following:
--exclude
option is now implemented. Previously, the flag was defined, but was ignored entirely.--exclude-index
or--exclude
will also impact random when the--book
option is used. Previously, the--book
option ignored exclusions.This pull request includes changes to improve the handling of excluded references and enhance error handling when looking up books in the
random
package. The most important changes include initializing theexcludeRefs
slice, appending toexcludeRefs
correctly, and improving error messages for book lookups.Improvements to handling excluded references:
cmd/random.go
: Initialized theexcludeRefs
slice and appended excluded references to it before applying theExcludeReferences
option. [1] [2]Enhancements to error handling:
pkg/ref/random.go
: Improved error handling when looking up books by adding detailed error messages and ensuring the first verse of the book is used correctly.