Translation form: customizable field labels #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielvdp
force-pushed
the
feature/translation-form-customizable-labels
branch
from
f58ffc8
to
7b53162
Compare
danielvdp
commented
Jul 20, 2021
Comment on lines
+251
to
+252
| fallback_label = "default language" | ||
| translation_label = "new language" |
There was a problem hiding this comment.
Or do we prefer something more compact like:
Suggested change
| fallback_label = "default language" | |
| translation_label = "new language" | |
| labels = {"fallback_label": "default language", "translation_label": "new language"} |
danielvdp
commented
Jul 20, 2021
Comment on lines
+21
to
+24
| self.labels = { | ||
| "fallback": getattr(options, "fallback_label", _("fallback language")), | ||
| "translation": getattr(options, "translation_label", _("translation language")), | ||
| } |
There was a problem hiding this comment.
In the more compact version, this would become
Suggested change
| self.labels = { | |
| "fallback": getattr(options, "fallback_label", _("fallback language")), | |
| "translation": getattr(options, "translation_label", _("translation language")), | |
| } | |
| labels = getattr(options, "labels", {}) | |
| self.labels = { | |
| "fallback": labels.get("fallback_label", _("fallback language")), | |
| "translation": labels.get("translation_label", _("translation language")), | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds customizable labels to the TranslationModelForm as Meta options.
Fixes: #70