Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Django versions and CI link in README and documentation #95

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

browniebroke
Copy link
Contributor

@browniebroke browniebroke commented Apr 17, 2023

Not sure if you also want to remove the fallback code for Django < 3.1:

try:
# django==3.1 moved JSONField into django.db.models
from django.db.models import JSONField
from django.db.models.fields.json import KeyTextTransform
except ImportError:
from django.contrib.postgres.fields import JSONField
from django.contrib.postgres.fields.jsonb import KeyTextTransform

@jieter
Copy link
Member

jieter commented Aug 3, 2023

Not sure if you also want to remove the fallback code for Django < 3.1:

try:
# django==3.1 moved JSONField into django.db.models
from django.db.models import JSONField
from django.db.models.fields.json import KeyTextTransform
except ImportError:
from django.contrib.postgres.fields import JSONField
from django.contrib.postgres.fields.jsonb import KeyTextTransform

Yes please!

@jieter jieter closed this Aug 3, 2023
@jieter jieter reopened this Aug 3, 2023
@browniebroke
Copy link
Contributor Author

Should be all done now

Copy link
Member

@jieter jieter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jieter jieter merged commit e524308 into zostera:master Aug 15, 2023
18 checks passed
@browniebroke browniebroke deleted the update-readme branch August 15, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants