Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Pull-request test: update the selector of the button for extensi… #3003

Merged

Conversation

zoe-translates
Copy link
Collaborator

…ons.

This should fix the recent CI failures. The element's id is now "btn-extensions-value".

…ons.

This should fix the recent CI failures. The element's id is now
"btn-extensions-value".
@zoe-translates
Copy link
Collaborator Author

For the interested: the change was introduced in chromium/chromium@27b2842

@zoe-translates
Copy link
Collaborator Author

See also zotero/translate#20. Because of that issue, the Selenium test here doesn't seem to test what it is supposed to test.

@zoe-translates
Copy link
Collaborator Author

zoe-translates commented Mar 27, 2023

The series of issues that render the Selenium test invalid.

Consequently, our current CI script for testing pull requests...

get_translators_to_check
./selenium-test.js "$TRANSLATORS_TO_CHECK"

  • Cannot be run on the recent versions of Google Chrome by Selenium
    • ❌ The immediate cause of recent PR test failures.
  • Even when the Chrome compatibility wasn't an issue, the tests for the modified translator(s) in the PR were not actually run in the testing tool, because the tool silently skip the translators identified in the URL.
    • ✅ So the previous PR test successes were false negatives.
  • For non-web translators, the test will still fail by timeout (false positives), because the translator testing tool itself does not actually run any non-web tests.

@AbeJellinek AbeJellinek merged commit b3dc7f9 into zotero:master Apr 3, 2023
@AbeJellinek
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants