Add support for Kluwer Arbitration #3161
Conversation
|
The translator works for most documents found on Kluwer Arbitration, but not all options have been explored yet. In particular, I have not been able to run any tests within Scaffold because the JSON requests return null. I thought it was a VPN issues but the integrated browser follows redirections and displays the full document. EDIT: apparently Scaffold does not use cookies correctly in Zotero 6, was able to use Zotero 7 to generate the test cases. Search is still WIP |
Thanks to Zotero 7, was able to include multiple tests
|
Ready for production IMO, however the linter seems to complain about the Nullish coalescing assignment ( |
|
Hello, thank you for the contribution! I'd be more than happy to test and review, but unfortunately I don't have access to the Kluwer Arbitration. So all I can do for now is to provide some comments about the coding itself. Nullish coalescing assignment: This is an ES2020 feature, and the repo's ESLint config is set to ES2018. I don't think any other translator uses |
|
In fact, with the |
Followed most of the review points, left `async` for now until there's more opinions on this. Will update again when remaining points have been clarified
Better handles the case where the ISBN search failed and relying on Kluwer itself as a fallback.
Refactored search logic and arbitration blog logic (supports multiples blog articles as well). All items set their URL now. Snapshots were considered but rejected since they only offer marginal improvements at a considerably larger size (footnote callout number are not clickable, only improvement is that in the endnotes the numbers are clickable).
|
Thank you so much @zoe-translates and @dstillman for your reviews! If all is ok now, when can we expect the PR to be merged? |
… cases - Saving dates in ISO format - When `date` was set for cases or statutes published in a publication, `dateDecided` and `dateEnacted` respectively were ignored
|
I'd like to get this merged! Unfortunately I have no access to the site at all. @thebluepotato, could you verify that tests all still pass for you? |
|
Hi! I updated some of the code and tests, and they all passed successfully! Thank you so much for looking at this. While I have you here, could you look at #3169 as well? I'll be checking if the tests still work, but this is publicly accessible anyway. |
|
Btw I think something might be wrong with your CI code as the checks seem to fail despite me running the linter locally |
|
@AbeJellinek This PR is also ready for re-review |
Very alpha for now, but adds support for articles and books from Kluwer Arbitration. I should probably add blog posts at some point.