Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenAlex translators #3379

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update OpenAlex translators #3379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
628b570
Update OpenAlex translators
thebluepotato Oct 24, 2024
5b855de
Merge remote-tracking branch 'upstream/master' into openalex
thebluepotato Oct 24, 2024
3b440ae
Cleanup stray comments
thebluepotato Oct 24, 2024
f7e71be
Remove DOI fallback due to lack of benefit
thebluepotato Nov 2, 2024
b95bc2d
Cleanup
thebluepotato Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/eslint-plugin-zotero-translator/lib/rules/test-cases.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ module.exports = {
}
else if (testCase.type === 'search') {
// console.log(JSON.stringify(testCase.input))
const expected = ['DOI', 'ISBN', 'PMID', 'arXiv', 'identifiers', 'contextObject', 'adsBibcode', 'ericNumber', 'openAlex'];
const expected = ['DOI', 'ISBN', 'PMID', 'arXiv', 'identifiers', 'contextObject', 'adsBibcode', 'ericNumber', 'OpenAlex'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing this back?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I'd align with the way it's usually written and displayed. For instance, arXiv is not lowercase, DOI is uppercase, etc. I'm fine with anything in the end, but wouldn't it be better if the label was case insensitive?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The non-camelcase key names for DOI, ISBN, and PMID have caused us some grief, which is why we haven't done that with adsBibcode (ADS Bibcode) or ericNumber (ERIC number).

let keys;
if (Array.isArray(testCase.input)) {
keys = testCase.input.flatMap(Object.keys);
Expand Down
Loading
Loading