feat: Update IMDb.js to add URL to item #3385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test failed wtih:
```
TranslatorTester: Running IMDb Test 2
TranslatorTester: Translating https://www.imdb.com/find?q=shakespeare&s=tt
TranslatorTester: IMDb Test 2: failed (Detection failed)
```
The existing `multiple` check checked for `/find?` in url but IMDb is updating the URL to `/find/?` which is failing the check.
Example URL: https://www.imdb.com/find/?q=shakespeare&s=tt
|
I don't think this is really correct. We could add a Snapshot attachment, but the URL field is for URLs where full-text (full-film?) content can be found. IMDb is a catalog site akin to a library catalog; we don't add URLs for those. (I'm also confused about the seemingly unrelated changes to the URL check and XPaths.) |
|
Hi, Thanks for checking my PR. Oh, I didn't know that about the URL field. I just checked the documentation and it does mention the same. Thanks for clariyfing that. Regarding the xpath changes, the search page xpaths have changed and was making the test cases fail so tried to update them but couldn't make it work. I will go ahead and close this PR as the primary change is not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
IMDb.js:scrape(...)methodNotes
Testing